Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple files to enhance functionality, fix typos, and improve code quality. The most significant updates include adding new Makefile commands for formatting and linting, fixing a recurring typo in the
get_compression_from_namefunction and related usages, and adding a module-level docstring and exports insrc/connect/__init__.py.Build and Development Enhancements:
formatandlintcommands to streamline code formatting and linting usingruff,mypy, andpyright.Code Quality Improvements:
compresiontocompressionacross several files, includingsrc/connect/compression.py,src/connect/client.py,src/connect/protocol_connect/connect_client.py, andsrc/connect/protocol_grpc/grpc_client.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Documentation and Initialization:
__all__exports insrc/connect/__init__.pyto improve module documentation and clarify public API elements.Minor Bug Fix:
src/connect/content_stream.pyby changingself.closedtoself._closedto ensure proper attribute usage.Configuration Updates:
pydocstyleconfiguration with the "google" convention to enforce consistent docstring styles.